Repository navigation
fix(bump-consumers): name the missing secret instead of gh's login… - #52
Merged
Merged
Conversation
A dispatch without MAROLA_BUMP_TOKEN reached gh with an empty GH_TOKEN, which fails with "You are not logged into any GitHub hosts". Fail first, naming the secret. Tested: GH_TOKEN= bump-consumers.sh 0.6.0 exits 1 with the new message; --self-test; shellcheck; tests/self-tests.sh Cost: n/a (no measured figure in this cloud session) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: the first
bump consumersdispatch failed with gh's "You are not logged into any GitHub hosts", becauseMAROLA_BUMP_TOKENisn't set and the job passedghan emptyGH_TOKEN. The script now stops first and names the secret. Replaces #51, which came from a generic branch name.GH_TOKEN= bump-consumers.sh 0.6.0exits 1 with the new message;--self-test; shellcheck;tests/self-tests.shThe workflow itself was already right (
GH_TOKEN: ${{ secrets.MAROLA_BUMP_TOKEN }}); the run needs the secret set on marola-devkit.Generated by Claude Code