Skip to content

docs(agent-feedback): file text body and non-null assertion gaps - #259

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-marko-invariants-jcdpv7
Sep 28, 2026
Merged

DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-marko-invariants-jcdpv7

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Files the parser gaps left after 5.18.0. Text-only bodies are lexed as JavaScript, so prose and CSS bodies need a mode that recognizes only placeholders and the closing tag (<title>It's</title> fails today), and <script> bodies need regex literals lexed so /["']/g does not open a string. A TypeScript ! after whitespace or after } is still read as a prefix operator.

Also updates the escaped-quote item with the <script> regex cases it covers (/\"/g runs to the end of the file, and /^https?:\/\// silently comments out the rest of its line), and a fix direction that keeps \</style> closing its tag.

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a85cd0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (05d5789) to head (a85cd0a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          35       35           
  Lines        4711     4711           
  Branches      912      912           
=======================================
  Hits         4706     4706           
  Misses          4        4           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

File the parser gaps left after 5.18.0. Text-only bodies are lexed as
JavaScript, so prose and CSS bodies need a mode that recognizes only
placeholders and the closing tag (`<title>It's</title>` fails today), and
`<script>` bodies need regex literals lexed so `/["']/g` does not open a
string. A TypeScript `!` after whitespace or after `}` is still read as a
prefix operator.

Also update the escaped-quote item with the `<script>` regex cases it
covers (`/\"/g` runs to the end of the file, and `/^https?:\/\//` silently
comments out the rest of its line), and a fix direction that keeps
`\</style>` closing its tag.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@DylanPiercey
DylanPiercey force-pushed the dpiercey-ws-marko-invariants-jcdpv7 branch from 626839c to a85cd0a Compare September 28, 2026 17:05
@DylanPiercey
DylanPiercey merged commit 3b59c74 into main Sep 28, 2026
8 checks passed
@DylanPiercey DylanPiercey self-assigned this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant