Skip to content

docs: explain why | is an unconditional tag-variable terminator#231

Closed
DylanPiercey wants to merge 0 commit into
mainfrom
dpiercey-ws-agents-feedback-i8bbdl
Closed

docs: explain why | is an unconditional tag-variable terminator#231
DylanPiercey wants to merge 0 commit into
mainfrom
dpiercey-ws-agents-feedback-i8bbdl

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Documents why | must stay an unconditional terminator in the tag-variable scanners, so the "parenthesize your union" requirement is not re-investigated as a parser bug.

| is overloaded — it is both the TS union separator and the tag-body-parameters delimiter. Unlike < (which returns !expression.inType because generic brackets are balanced), | cannot be made type-aware: a typed tag variable can be immediately followed by body params, e.g.

<my-list/ref: Api|item, index|>...</my-list>

which must parse as tag variable ref: Api + params item, index. Making | non-terminating inside a type annotation swallows the |params| into the type as a union (this was tried in #230 and reverted). A union type annotation must therefore be parenthesized: (string | null).

Comment-only; no behavior change, no snapshot changes.

@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 93850d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d67647ee-d74a-4af2-aed5-dba018bdf0b0

📥 Commits

Reviewing files that changed from the base of the PR and between 93850d2 and a58a797.

📒 Files selected for processing (1)
  • src/states/OPEN_TAG.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dpiercey-ws-agents-feedback-i8bbdl

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.92%. Comparing base (93850d2) to head (a58a797).

Files with missing lines Patch % Lines
src/states/OPEN_TAG.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   99.95%   99.92%   -0.03%     
==========================================
  Files          34       34              
  Lines        4270     4274       +4     
  Branches      793      793              
==========================================
+ Hits         4268     4271       +3     
- Misses          2        3       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey

Copy link
Copy Markdown
Contributor Author

Closing — the equivalent decision comment now lives at the marko compiler consumer (parser.js onTagVar, merged in marko-js/marko#3506), which is where an agent investigating the EOF reached while parsing expression failure lands. That breadcrumb is sufficient; no need for a duplicate here.

@DylanPiercey
DylanPiercey force-pushed the dpiercey-ws-agents-feedback-i8bbdl branch from a58a797 to 93850d2 Compare July 21, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant