docs: explain why | is an unconditional tag-variable terminator#231
docs: explain why | is an unconditional tag-variable terminator#231DylanPiercey wants to merge 0 commit into
Conversation
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 99.95% 99.92% -0.03%
==========================================
Files 34 34
Lines 4270 4274 +4
Branches 793 793
==========================================
+ Hits 4268 4271 +3
- Misses 2 3 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Closing — the equivalent decision comment now lives at the marko compiler consumer ( |
a58a797 to
93850d2
Compare
Documents why
|must stay an unconditional terminator in the tag-variable scanners, so the "parenthesize your union" requirement is not re-investigated as a parser bug.|is overloaded — it is both the TS union separator and the tag-body-parameters delimiter. Unlike<(which returns!expression.inTypebecause generic brackets are balanced),|cannot be made type-aware: a typed tag variable can be immediately followed by body params, e.g.which must parse as tag variable
ref: Api+ paramsitem, index. Making|non-terminating inside a type annotation swallows the|params|into the type as a union (this was tried in #230 and reverted). A union type annotation must therefore be parenthesized:(string | null).Comment-only; no behavior change, no snapshot changes.