Conversation
| "testData", | ||
| "build/test-libs" | ||
| ); | ||
|
|
There was a problem hiding this comment.
Why did you changes this code? I think this could break building on other OS (Windows)
There was a problem hiding this comment.
I added this specifically to ensure the tests run correctly on Windows. Without these configurations, the testing framework is unable to access packages
There was a problem hiding this comment.
For example, before fix
14:52:40,037 FINE .intellij.openapi.command.impl - finishCommand: name = Renaming method setTestName(String) of class org.mapstruct.intellij.test.examples.SimpleMapper.Target to setNewName, groupId = null
14:52:40,039 SEVERE #TestFramework - Test failed
com.intellij.openapi.vfs.newvfs.impl.VfsRootAccess$VfsRootAccessNotAllowedError: File accessed outside allowed roots: file://D:/projects/github/mapstruct-idea/testData/usages/RenameTargetReferenceAfter.java; There was a problem hiding this comment.
@maybetm did you have the project not on your main disc (C:)?
19196bd to
30b3520
Compare
30b3520 to
d781aa0
Compare
d781aa0 to
f9e342b
Compare
|
@maybetm sorry for the late response. I saw that you fixed my previous findings. I’ll re-review your PR soon. |
Hi!☺️ I noticed that the MapStruct IDEA plugin didn't support generics properly in some cases.
This PR adds support for generic types. I'd appreciate it if you could review and merge these changes!
Before
After