Skip to content

Stop save_locally defaulting to the installed package directory #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caglarpir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop save_locally defaulting to the installed package directory #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/mapillary/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ def image_from_key(key: str, fields: list = []) -> str:
@auth()
def save_locally(
geojson_data: str,
file_path: str = os.path.dirname(os.path.realpath(__file__)),
file_path: str = None,
file_name: str = None,
extension: str = "geojson",
) -> None:
Expand All @@ -979,7 +979,8 @@ def save_locally(
:param geojson_data: The GeoJSON data to be stored
:type geojson_data: str

:param file_path: The path to save the data to. Defaults to the current directory path
:param file_path: The directory to save the data to. Defaults to the current
working directory
:type file_path: str

:param file_name: The name of the file to be saved. Defaults to 'geojson'
Expand All @@ -1006,18 +1007,24 @@ def save_locally(
>>> mly.interface.set_access_token('MLY|XXX')
>>> mly.interface.save_locally(
... geojson_data=geojson_data,
... file_path=os.path.dirname(os.path.realpath(__file__)),
... file_path='./output',
... file_name='test_geojson',
... extension='geojson'
... )
>>> mly.interface.save_locally(
... geojson_data=geojson_data,
... file_path=os.path.dirname(os.path.realpath(__file__)),
... file_path='./output',
... file_name='local_geometries',
... extension='csv'
... )
"""

# Resolve the default at call time, not at import time. Binding it to the
# module's own directory made the default write target the installed
# package inside site-packages.
if file_path is None:
file_path = os.getcwd()

# Check if a valid file format was provided
if extension.lower() not in ["geojson", "csv"]:
# If not, raise an error
Expand Down
Loading