Repository navigation
Conversation
kkaefer
force-pushed
the
kk/fix-sign-conversion-commit-submessage
branch
from
October 8, 2026 12:41
32d4fe8 to
8eadf02
Compare
kkaefer
added this pull request to stack #158
October 8, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the following compilation warning under
-Wsign-conversion:The return value from
add_varint_to_bufferis a signed integer. Technically, it should be unsigned since it can never be negative, but changing this would cause an API change, so we just keep it as is.