Review fixes: plugin docs, dynamic write-path test, claim corrections, presence-mode naming policy - #213
Open
manuc66 wants to merge 7 commits into
Open
Conversation
…ssembly, RegisterDynamicSubtype) The audits flagged these public features as entirely undocumented. Add a README section with a runnable example, a MIGRATION pointer, and a CHANGELOG entry. Also document the name-based security implication for plugin assemblies.
…rter The STJ converter write path is streamed since the Utf8JsonReader rework; only the AOT generator still round-trips through a JsonDocument. The MaxDepth +1 note, the 2-3x memory note and the engine comparisons claimed the round-trip for both. Scope them to the generator and refresh the STJ test count (202).
Re-measured the converter scenarios on the same machine: the write side no longer round-trips through a JsonDocument, so serialization allocations dropped (Single 856B->784B, Collection 3288B->2.93KB). Runtime updated to .NET 10.0.10 and a note explains which engine still carries the JsonDocument cost.
…ed presence mode The generated SelectType matched presence properties with the literal name, ignoring both options that the runtime converter honors. Route the lookup through the shared TryGetProperty helper (which already applies the naming policy and case-insensitive fallback), regenerate the golden master and cover the three cases with tests.
The '202 unit tests' count covered only the converter suite. Spell out the whole STJ family: 202 converter tests, 84 generated-converter tests plus 14 Native-AOT-only, 74 generator tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two external code reviews of the branch flagged: the plugin pattern undocumented, the golden master stale after the generator fix, stale README claims (JsonDocument round-trip, test count, performance numbers), the dynamic write path untested, and the generated presence mode ignoring naming policy / case-insensitivity.
Fix
Tests
Honest note(s)