Skip to content

Harden Playerbot event processing and diagnostics - #479

Merged
MadMaxMangos merged 4 commits into
masterfrom
fix/playerbot-architecture-followups
Aug 20, 2026
Merged

MadMaxMangos merged 4 commits into
masterfrom
fix/playerbot-architecture-followups

Conversation

@MadMaxMangos

@MadMaxMangos MadMaxMangos commented Aug 20, 2026 •

Copy link
Copy Markdown
Member

Summary

  • bound Playerbot action-log formatting and write formatted messages as literal text
  • preserve FIFO arrival order for queued external events without inserting unknown handlers
  • reject invalid or non-logged-in queued opcodes, retain packet ownership through dispatch, and contain malformed packet parsing
  • add opt-in packet, event-query, and AI-evaluation performance counters via AiPlayerbot.PerformanceMetricsInterval

Verification

  • ctest --test-dir E:\Mangos\WIP\Zero\Testing\server_build_playerbot_arch_followups -C RelWithDebInfo --output-on-failure
  • 15/15 tests passed, including the Playerbot log, queue, packet-policy, and performance-monitor coverage
  • deployed ab6114c0 runtime smoke with 30 random bots online and active combat, XP, and loot processing; no crash, assertion, malformed packet, or invalid-opcode symptom observed
  • each focused commit received a bounded Claude Opus 5 review; final verdicts approved with no blocking or important findings

Scope

Existing random-bot death, revive, and teleport churn was observed during the smoke test and is intentionally left for a separate focused investigation.


This change is Reviewable

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 44 complexity · 0 duplication

Metric Results
Complexity 44
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@MadMaxMangos
MadMaxMangos marked this pull request as ready for review August 20, 2026 22:28
@MadMaxMangos
MadMaxMangos merged commit 3f45817 into master Aug 20, 2026
7 of 8 checks passed
@MadMaxMangos
MadMaxMangos deleted the fix/playerbot-architecture-followups branch August 20, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant