Skip to content

Fix empty array parsing #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malthe merged 1 commit into from
Oct 30, 2026
Merged

Fix empty array parsing #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,9 @@ export function readRowData(

offset += 4;

if (dimCount === 0) {
if (dimCount < 0) {
value = [];
} else if (dimCount === 0) {
const size = buffer.readInt32BE(offset);
offset += 8;
value = readArray(size);
Expand Down
5 changes: 5 additions & 0 deletions test/result.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ describe('Result', () => {
deepEqual(row.a, [null]);
});

test('Parse empty array', async ({ client }) => {
const row = await client.query("select '{}'::text[] as a").one();
deepEqual(row.a, []);
});

test('Format array containing null value', async ({ client }) => {
const row = await client
.query('select $1::text[] as a', [[null]])
Expand Down
Loading