Skip to content

fix(web): merge duplicate settings entries in user menu - #9794

Open
Liewzheng wants to merge 1 commit into
makeplane:masterfrom
Liewzheng:fix/user-menu-single-settings-entry
Open

fix(web): merge duplicate settings entries in user menu#9794
Liewzheng wants to merge 1 commit into
makeplane:masterfrom
Liewzheng:fix/user-menu-single-settings-entry

Conversation

@Liewzheng

Copy link
Copy Markdown

Description

The user avatar dropdown in the workspace sidebar listed two visually duplicate entries — Settings and Preferences — both opening the same profile settings modal (toggleProfileSettingsModal) with only the initial tab differing (general vs preferences).

This PR removes the Preferences menu item and keeps a single Settings entry that opens the modal on the general tab. Preferences are still reachable via the Preferences tab inside the modal.

Also cleaned up the now-unused top-level preferences translation key from common.json in all locales, since this menu item was its only reference.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Test Scenarios

  • Open the user avatar dropdown in the sidebar: only one Settings entry (gear icon) is shown.
  • Clicking it opens the profile settings modal on the General tab.
  • Switching to the Preferences tab inside the modal still works.
  • check:types passes for web and @plane/i18n; oxlint/oxfmt clean on changed files.

References

Closes #9793

@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 9, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~2 changed · 🔴 -0 removed · 0 flows · 20 files · commit d23188c


Architecture

Architecture diagram for makeplane/plane at d23188c

2 components touched across 2 lanes.

Open the interactive canvas


Data flow

No data-flow sequence changed in this PR.


Drill down
Client Applications — 2 components
🟡 CHANGED Plane Web App

Next.js web client hosting workspace navigation and sidebar user profile menu.

🟡 CHANGED I18n Localization (@⁠plane/i18n)

Localization package managing translation dictionaries across 19 supported languages.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail
  • Show unchanged neighbours

Tip

Push a new commit and the whole comment re-renders for the new head. An older run never overwrites a newer one, so a slow render cannot put a stale diagram back.

🪧 More tips
  • Run PR Lens on your own machine: npx skills add coldteadotai/pr-lens installs the agent skill. Then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Draw a diff before it is even a pull request: npx @coldtea/pr-lens-cli analyze --base origin/main reads the diff with your own model key, and npx @coldtea/pr-lens-cli render .pr-lens/graph.json draws the same lenses on your machine.
  • The boxes under View are live. Tick Architecture lens or Data flow lens to choose which diagrams appear, or Expand every detail to open every drill-down at once. The comment redraws in place a few seconds later.
  • Show unchanged neighbours lists the components this change did not touch alongside the ones it did, so the drill-down shows what the changed code sits next to.
  • GitHub will not let you zoom an image in a comment. The link under each diagram opens it on an interactive canvas, where you can zoom, pan and step through the flow.
  • The CLI's render picks up .github/pr-lens.yml automatically and applies your corrections (renames, exclusions, lane pins) at draw time.
  • Would you rather run it from CI on a key of your own? Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and a model key in your repository secrets, say GEMINI_API_KEY. The Action asks Gemini by default, or OpenAI and any endpoint speaking /chat/completions through its provider input.
  • PR Lens is free for open source. A star on the repository is what keeps it going.
  • The diagrams follow your GitHub theme, so dark mode gets the dark render and light mode the light one, and the moving dots show this pull request's data in motion.

◈ Rendered by PR Lens · crafted with ❤️ by the Coldtea team · Come say hi on Discord

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: eb890174-1e6b-4474-bf2e-cb7050c20080

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant