Skip to content

fix(i18n): translate remaining English labels in zh-CN settings and GitHub Enterprise form - #9778

Open
Liewzheng wants to merge 1 commit into
makeplane:previewfrom
Liewzheng:fix/i18n-zh-cn-settings-labels
Open

fix(i18n): translate remaining English labels in zh-CN settings and GitHub Enterprise form#9778
Liewzheng wants to merge 1 commit into
makeplane:previewfrom
Liewzheng:fix/i18n-zh-cn-settings-labels

Conversation

@Liewzheng

@Liewzheng Liewzheng commented Sep 8, 2026

Copy link
Copy Markdown

Description

Several high-visibility labels still render in English in the Simplified Chinese UI:

  • Settings sidebar group labelsAdministration, Developer, Your profile, Work structure, Execution, Completed on, Forum (common.json). These show on every settings page, mixed into an otherwise fully Chinese navigation.
  • GitHub Enterprise integration form (integration.json) — Base URL, Client ID, Client Secret, Webhook Secret, App Slug, App ID and their error messages were in English while the GitLab Enterprise block in the same file is fully translated. Translated following the GitLab block's existing terminology (基础 URL, 客户端 ID, 客户端密钥, Webhook 密钥, ...).

Per .claude/skills/translate, these are common nouns, not brand marks, so they are translated. A full audit of zh-CN against en confirmed everything else English-looking is intentional (placeholders, brand names, Webhooks/Cron kept in English across all locales).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Test Scenarios

  • pnpm --filter @plane/i18n run check:sync — all locales in sync, no issues
  • pnpm --filter @plane/i18n run check:types — passes
  • Verified terminology consistency against existing zh-CN entries (created_on → 创建于, profile → 个人资料, GitLab Enterprise block terms)

References

Summary by CodeRabbit

  • Localization
    • Updated Simplified Chinese translations for navigation, project fields, and project structure labels.
    • Fully translated GitHub Enterprise integration labels, descriptions, placeholders, and error messages.
    • Clarified that the private key description refers to a Base64-encoded private key.

@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 8, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~1 changed · 🔴 -0 removed · 0 flows · 2 files · commit 182cac2


Architecture

Architecture diagram for makeplane/plane at 182cac2

1 component touched across 1 lane.

Open the interactive canvas


Data flow

No data-flow sequence changed in this PR.


Drill down
Client Applications — 1 component
🟡 CHANGED I18n Localization (@⁠plane/i18n)

Provides internationalization dictionaries and localization utilities for client applications.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail
  • Show unchanged neighbours

Tip

Push a new commit and the whole comment re-renders for the new head. An older run never overwrites a newer one, so a slow render cannot put a stale diagram back.

🪧 More tips
  • Run PR Lens on your own machine: npx skills add coldteadotai/pr-lens installs the agent skill. Then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Draw a diff before it is even a pull request: npx @coldtea/pr-lens-cli analyze --base origin/main reads the diff with your own model key, and npx @coldtea/pr-lens-cli render .pr-lens/graph.json draws the same lenses on your machine.
  • The boxes under View are live. Tick Architecture lens or Data flow lens to choose which diagrams appear, or Expand every detail to open every drill-down at once. The comment redraws in place a few seconds later.
  • Show unchanged neighbours lists the components this change did not touch alongside the ones it did, so the drill-down shows what the changed code sits next to.
  • GitHub will not let you zoom an image in a comment. The link under each diagram opens it on an interactive canvas, where you can zoom, pan and step through the flow.
  • The CLI's render picks up .github/pr-lens.yml automatically and applies your corrections (renames, exclusions, lane pins) at draw time.
  • Would you rather run it from CI on a key of your own? Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and a model key in your repository secrets, say GEMINI_API_KEY. The Action asks Gemini by default, or OpenAI and any endpoint speaking /chat/completions through its provider input.
  • PR Lens is free for open source. A star on the repository is what keeps it going.
  • The diagrams follow your GitHub theme, so dark mode gets the dark render and light mode the light one, and the moving dots show this pull request's data in motion.

◈ Rendered by PR Lens · crafted with ❤️ by the Coldtea team · Come say hi on Discord

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 76f2e60b-819a-4998-a841-cabd99e7a2fa

📥 Commits

Reviewing files that changed from the base of the PR and between 1fec307 and 182cac2.

📒 Files selected for processing (2)
  • packages/i18n/src/locales/zh-CN/common.json
  • packages/i18n/src/locales/zh-CN/integration.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The zh-CN locale now translates common interface labels and all GitHub Enterprise integration form strings into Simplified Chinese. Existing keys remain unchanged.

Changes

Simplified Chinese localization

Layer / File(s) Summary
Common interface labels
packages/i18n/src/locales/zh-CN/common.json
Translated the forum, completed_on, and settings section labels into Simplified Chinese.
GitHub Enterprise form labels
packages/i18n/src/locales/zh-CN/integration.json
Translated GitHub Enterprise field labels, descriptions, placeholders, and error messages. The private key description now specifies a Base64-encoded private key.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 182ca

Simplified Chinese labels for shared settings and GitHub Enterprise configuration are now translated without changing locale keys or application behavior. The change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the translation of remaining Simplified Chinese labels in settings and the GitHub Enterprise form.
Description check ✅ Passed The description includes the change summary, change type, test scenarios, terminology validation, and issue reference. The omitted screenshots section is not required for this locale-only change.
Linked Issues check ✅ Passed The changes satisfy issue #9777 by translating the specified zh-CN settings labels and GitHub Enterprise form text while preserving keys and locale synchronization.
Out of Scope Changes check ✅ Passed All reported changes are limited to the translation objectives in issue #9777. The private key description correction is relevant to the GitHub Enterprise localization work.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: zh-CN settings sidebar and GitHub Enterprise form labels still in English

1 participant