feat(plugin): register iOS simulator host slot - #45
Open
horizon554 wants to merge 1 commit into
Open
Conversation
Signed-off-by: JiangJiahao <jiangjiahao@xd.com>
horizon554
marked this pull request as ready for review
August 7, 2026 09:54
|
| Filename | Overview |
|---|---|
| packages/plugin-protocol/src/manifest.ts | 新增 ios-simulator slot,并在既有严格 SemVer 校验基础上强制要求显式版本门槛;未发现可达缺陷。 |
| packages/plugin-protocol/src/tests/manifest.test.ts | 覆盖新 slot 的成功往返、缺少版本门槛及未知近似 slot 的拒绝路径。 |
| packages/plugin-protocol/src/tests/delivery.test.ts | 验证插件详情解析会完整保留新 slot 与版本门槛字段。 |
| docs/plugin-protocol.md | 说明插件权限边界、版本筛选要求、协议包职责边界及消费方部署顺序。 |
Reviews (1): Last reviewed commit: "feat(plugin): register iOS simulator hos..." | Re-trigger Greptile
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
动机 / Motivation
为 Cindy Host 托管的内嵌 iOS Simulator 正式登记共享 manifest capability slot,使 Plugin Server、Desktop 与插件作者使用同一白名单和运行时校验,不再依赖消费方私有扩展。
Register a shared manifest capability slot for the Cindy Host-owned embedded iOS Simulator, so Plugin Server, Desktop, and plugin authors use the same allowlist and runtime validation instead of consumer-local extensions.
变更类型 / Change type
兼容性影响 / Compatibility impact
这是 schema v2 的严格、append-only slot 扩展,不提升 manifest schema 版本。既有插件不受影响。旧 Plugin Server/Desktop 会对未知 slot fail closed,因此声明
ios-simulator时强制要求minCindyVersion;服务端可据X-Cindy-Version避免向旧客户端交付不兼容 Release。发布顺序应为:先合并本协议并升级、部署 Plugin Server 与 Cindy Host,再发布使用该 slot 的插件。This is a strict, append-only schema-v2 slot extension with no manifest schema bump. Existing plugins are unaffected. Older Plugin Server/Desktop builds fail closed on unknown slots, so
ios-simulatorrequiresminCindyVersion; the server can useX-Cindy-Versionto withhold incompatible releases. The protocol and its server/Host consumers must be deployed before publishing a plugin that declares this slot.「三件套」自查(协议变更必须全部勾选) / The "trio" (required for protocol changes)
docs/对应章节) / Docs (the relevantdocs/section)检查项 / Checklist
pnpm test与pnpm typecheck通过 /pnpm testandpnpm typecheckpass验证 / Validation
pnpm testpnpm typecheckpnpm lintpnpm format:check