Skip to content

Move CES parser to separate project (separate Nuget package). - #122

Merged
davidatwhiletrue merged 3 commits into
masterfrom
ces-parser-package
Oct 16, 2026
Merged

davidatwhiletrue merged 3 commits into
masterfrom
ces-parser-package

Conversation

@davidatwhiletrue

@davidatwhiletrue davidatwhiletrue commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Summary

Moves CES parser to its own nuget package. No changes to implementation. Documentation and examples updated with new namespace and reference project.
Updates SDK version to 3.3.0.

TODO

Checklist

  • Code is properly formatted
  • All commits are signed
  • Tests included/updated or not needed
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: David Hernando <david.hernando@make.services>
Signed-off-by: David Hernando <david.hernando@make.services>

@Comp0te Comp0te left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the move of the CES parser into its own Casper.Network.SDK.CES project and package, including the publish workflow and docs. One small follow-up on how the new package is referenced from source.

dotnet add package Casper.Network.SDK
```

For Casper Event Standard schema and event parsing, also install `Casper.Network.SDK.CES` and import `Casper.Network.SDK.CES`. See the [CES guide](./CasperEventStandard.md).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note points NuGet users to Casper.Network.SDK.CES, but the "Add a reference to the source code" section just below still names only Casper.Network.SDK.csproj. CES no longer compiles into that project. So anyone who references the SDK from source and then follows the CES guide gets unresolved Casper.Network.SDK.CES / CESParser symbols.

Could that section also mention the CES project, e.g. dotnet add reference ../casper-net-sdk/Casper.Network.SDK.CES/Casper.Network.SDK.CES.csproj?

Basis
  • CESParser moved from Casper.Network.SDK/CES/ to Casper.Network.SDK.CES/CESParser.cs, and Casper.Network.SDK.csproj has no reference to the new project.
  • The source-reference section is unchanged by this PR. The other docs that mention CES (CasperEventStandard.md, README.md, the CES README_nuget.md) only give the dotnet add package route.

Signed-off-by: David Hernando <david.hernando@make.services>

@Comp0te Comp0te left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidatwhiletrue
davidatwhiletrue merged commit 6906b54 into master Oct 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants