Repository navigation
Move CES parser to separate project (separate Nuget package). - #122
Conversation
Signed-off-by: David Hernando <david.hernando@make.services>
Signed-off-by: David Hernando <david.hernando@make.services>
Comp0te
left a comment
There was a problem hiding this comment.
Reviewed the move of the CES parser into its own Casper.Network.SDK.CES project and package, including the publish workflow and docs. One small follow-up on how the new package is referenced from source.
| dotnet add package Casper.Network.SDK | ||
| ``` | ||
|
|
||
| For Casper Event Standard schema and event parsing, also install `Casper.Network.SDK.CES` and import `Casper.Network.SDK.CES`. See the [CES guide](./CasperEventStandard.md). |
There was a problem hiding this comment.
This note points NuGet users to Casper.Network.SDK.CES, but the "Add a reference to the source code" section just below still names only Casper.Network.SDK.csproj. CES no longer compiles into that project. So anyone who references the SDK from source and then follows the CES guide gets unresolved Casper.Network.SDK.CES / CESParser symbols.
Could that section also mention the CES project, e.g. dotnet add reference ../casper-net-sdk/Casper.Network.SDK.CES/Casper.Network.SDK.CES.csproj?
Basis
CESParsermoved fromCasper.Network.SDK/CES/toCasper.Network.SDK.CES/CESParser.cs, andCasper.Network.SDK.csprojhas no reference to the new project.- The source-reference section is unchanged by this PR. The other docs that mention CES (
CasperEventStandard.md,README.md, the CESREADME_nuget.md) only give thedotnet add packageroute.
Signed-off-by: David Hernando <david.hernando@make.services>
Summary
Moves CES parser to its own nuget package. No changes to implementation. Documentation and examples updated with new namespace and reference project.
Updates SDK version to 3.3.0.
TODO
Checklist