Skip to content

Add Burn native entry point. Update TransactionBuilder accordingly. - #121

Merged
davidatwhiletrue merged 2 commits into
masterfrom
burn-native-entrypoint
Oct 15, 2026
Merged

davidatwhiletrue merged 2 commits into
masterfrom
burn-native-entrypoint

Conversation

@davidatwhiletrue

Copy link
Copy Markdown
Member

Summary

This PR adds missing Burn native entry point type.

TODO

Checklist

  • Code is properly formatted
  • All commits are signed
  • Tests included/updated or not needed
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: David Hernando <david.hernando@make.services>

@Comp0te Comp0te left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new Burn native entry point: the tag and its serialization, NativeBurnBuilder, and the new parse and builder tests. Both comments are about the checks around the new code: a required-arg check that can't fire, and a test that can't catch a wrong tag.

Comment thread Casper.Network.SDK/Types/TransactionBuilder.cs
Comment thread Casper.Network.SDK.Test/RPCResponses/GetNativeBurnTransactionTest.cs Outdated
Signed-off-by: David Hernando <david.hernando@make.services>

@Comp0te Comp0te left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidatwhiletrue
davidatwhiletrue merged commit ee8e6fc into master Oct 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants