Conversation
Map uname and ACP-registry CPU names (aarch64, x86_64) onto the pinned linux-arm64 archive, prefer the host machine over Node's compile arch, and fail with the existing unsupported message when no ARM build exists. Fixes pingdotgg#12490
Expand ~/ in the custom binary path and, when that path is a directory, look up agy_acp_server.par plus localharness_external inside it so a manual CDN extract passes the health check. Keep host-machine aarch64 mapping onto the pinned linux-arm64 archive. Fixes pingdotgg#12490 Fixes pingdotgg#12477
cursor
Bot
changed the title
CodeRabbit docstring coverage on the linux-arm64 change was 50% because resolveAntigravityReleaseAsset had no TSDoc. Add one-line docs on the functions that diff already touched. Co-authored-by: maco <macodev00@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
One PR for both Linux ARM64 Antigravity bugs:
uname/ ACP-registry CPU names (aarch64,x86_64,amd64) onto the pinnedlinux-arm64/linux-x64archives, prefer the host machine over Node’s compile arch, and store the runtime underlinux-arm64. Unpublished CPUs fail immediately without downloading.~/in the custom binary path viaexpandHomePathWith. If the path is a directory (typical manual CDN extract), resolveagy_acp_server.parandlocalharness_externalinside it instead of treating the folder as missing.Why
On Linux ARM64,
uname -mand the official ACP registry sayaarch64while Node saysarm64. Lookup used the raw arch string, so built-in Install could miss Google’s linux-arm64 zip. Separately, Settings → Binary path often points at the extract folder or a~/…path; resolve required the ACP file itself and did not expand home, so the health check stayed on “not found” / generic failure.pingdotgg#12490
pingdotgg#12477
UI Changes
None.
Checklist