fix(web): keep thread notification tags within the Windows toast limit by macodev00 · Pull Request #6 · macodev00/t3code

macodev00 · 2026-09-20T08:59:57Z

What Changed

Desktop thread alerts now use threadNotificationTag(environmentId, threadId): a stable 16-character digest of the environment+thread pair. ThreadNotificationCoordinator passes that value as Notification.tag (and therefore as the pending-notification map key).

Why

Windows Chromium silently drops renderer notifications when the tag plus origin exceeds the platform toast budget. Production tags were environmentId:threadId (two UUIDs, 73 characters), so completion toasts never appeared even though sound and the taskbar badge still ran. A 16-hex digest stays under the documented 34-character bound while keeping per-environment, per-thread replacement.

Fixes pingdotgg#12287

Tests

vp test run --project unit in apps/web over the new helper test plus both coordinator files: 31 passed.

apps/web/src/threadNotifications.test.ts: tag is 16 hex characters, ≤ 32, stable, and distinct across environments and threads
Coordinator tests now expect the digest instead of the raw composite string

UI Changes

Not applicable; no visual changes.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation or interaction changes

…12438) Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

…10831) Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

)

…tgg#12657) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

…ion (pingdotgg#10098) Co-authored-by: shivamhwp <91240327+shivamhwp@users.noreply.github.com>

Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>

)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>

…12719)

…ingdotgg#12526)

)

) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>

…ingdotgg#12620)

…g#12808) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…off (pingdotgg#12807) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…s page (pingdotgg#12536) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

…2243) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>

…2805) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

…ikethrough (pingdotgg#12290)

pingdotgg#12833) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>

…ngdotgg#12848) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…g#12877)

…12843) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

…dotgg#12949) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…12950)

… the server from starting (pingdotgg#12763)

… does (pingdotgg#12745)

Co-authored-by: codex <codex@users.noreply.github.com>

…trees (pingdotgg#12953) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…ingdotgg#12954) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…otgg#12955) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…ngdotgg#12945) Co-authored-by: maria-rcks <maria@kuuro.net>

…gdotgg#12982) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…ingdotgg#12984) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…1148)

) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Windows Chromium silently drops renderer notifications when the tag is 73 characters (two UUIDs). Hash the environment+thread pair to a 16-character digest so the toast stays within the platform limit.

Assert the hashed tag for a production UUID pair so a change to the digest is an explicit test failure, and document the coverage cases CodeRabbit scores.

Bil0000 and others added 30 commits September 20, 2026 17:19

fix(web): honor whitespace settings in pull request diffs (pingdotgg#…

4a560b4

…12438) Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

fix(web): keep citation comment when popover is dismissed (pingdotgg#…

0ff87f2

…10831) Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

fix(web): keep narrow chat headers readable and aligned (pingdotgg#12453

c14f601

)

refactor(observability): hold OTLP export settings per signal (pingdo…

fa1e171

…tgg#12657) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

fix(web): explain what enabling network access means in its confirmat…

ead1dee

…ion (pingdotgg#10098) Co-authored-by: shivamhwp <91240327+shivamhwp@users.noreply.github.com>

fix(web): reuse current PR status in the sidebar (pingdotgg#12545)

9f0c9f7

fix(web): stabilize pull request loading layout (pingdotgg#12721)

6a699f0

Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>

fix(desktop): align preview recording cursors and show input feedback (…

55c2427

…pingdotgg#12779)

fix(web): the Run on / Workspace menu closes after a pick (pingdotgg#…

7ade2d2

…12685)

fix(web): keep portaled menus clickable over Electron drag regions (p…

3cfebf4

…ingdotgg#12527)

fix(web): render citations in queued messages (pingdotgg#12403)

5d9e27a

fix(web): keep the timeline still when the resting composer expands (p…

2d8f9a8

…ingdotgg#12771)

fix: composer hero reads project name to screen readers (pingdotgg#12397

45e06f4

)

fix(mobile): respect word wrap in diffs (pingdotgg#12590)

f6cc6bc

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>

fix(web): allow full contrast in assistant replies (pingdotgg#12405)

adcd908

fix(web): pull request chips share the link hover preview (pingdotgg#…

9334924

…12719)

fix(web): compact the worktree setup glass popover (pingdotgg#12802)

584450a

fix(web): route keyboard submit through the primary worktree action (p…

67285e4

…ingdotgg#12526)

fix(web): skip image inline chip when composer is empty (pingdotgg#12528

c789cd1

)

fix(web): only show notice details when text is clipped (pingdotgg#12760

f4d979a

) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>

fix(devices): recover simulator streams after failures (pingdotgg#12639)

9f73ca3

chore(server): bump device tooling versions (pingdotgg#12809)

1ba471a

fix: allow more attachments without raising the image payload budget (p…

2b17823

…ingdotgg#12620)

fix(web): device Reconnect starts one stream instead of two (pingdotg…

051a405

…g#12808) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

fix(server): tolerate shutting down an iOS simulator that is already …

58f8981

…off (pingdotgg#12807) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

feat(web): use the linked pull request row layout on the pull request…

411da2a

…s page (pingdotgg#12536) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

fix(clients): keep backslashes in copied Codex citations (pingdotgg#1…

2efb817

…2243) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>

feat(web): truncate branch names and paths in the middle (pingdotgg#1…

f7efb53

…2805) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

fix(web): paste markdown with inline code inside bold, italic, or str…

dca84ef

…ikethrough (pingdotgg#12290)

feat(web): show the pull request refresh spinning in the detail header (

a9ab904

pingdotgg#12833) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

maria-rcks and others added 25 commits September 21, 2026 02:11

fix(web): move sidebar shelves as one block (pingdotgg#11772)

f391b88

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>

fix(web): offer undo after unpinning a thread (pingdotgg#10744)

6b0a04a

feat(web): undo settle, snooze and archive, with a mod+z shortcut (pi…

5781b52

…ngdotgg#12848) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

fix(mobile): use a proper pull request icon on iOS (pingdotgg#12855)

1eeeabb

test(web): remove redundant favicon test (pingdotgg#12856)

b379b5b

feat(devices): offer manual updates in tool version details (pingdotg…

1de563c

…g#12877)

feat(web): answer pull request actions on the row at once (pingdotgg#…

371b52d

…12843) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

fix(mobile): stop iOS autocorrect from rewriting search queries (ping…

33cb911

…dotgg#12949) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

fix(web): pull request embed chip shows the state icon (pingdotgg#12951)

2c2fa8c

fix(web): dismiss selection actions when pressing buttons (pingdotgg#…

2d377bf

…12950)

fix(web): name message copy actions accurately (pingdotgg#12865)

d2a90b9

fix(contracts): old message-sent events without turnId no longer stop…

80d9c18

… the server from starting (pingdotgg#12763)

fix(web): the custom snooze calendar starts the week where the locale…

e1cbb70

… does (pingdotgg#12745)

chore(mobile): bump app version to 1.3.0

76cc9b0

Co-authored-by: codex <codex@users.noreply.github.com>

feat(server): let t3.json limit or disable submodule init in new work…

1262d2f

…trees (pingdotgg#12953) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

feat(settings): resolve t3.json inside the project settings resolver (p…

742173a

…ingdotgg#12954) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

feat(settings): choose how new worktrees initialize submodules (pingd…

0141bc2

…otgg#12955) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

fix(web): show thread undo notice in the sidebar (pingdotgg#12972)

9a609a4

feat(web): merge the comment and review buttons into one composer (pi…

5423ba0

…ngdotgg#12945) Co-authored-by: maria-rcks <maria@kuuro.net>

fix(web): allow text selection when renaming threads (pingdotgg#12935)

e65bc1c

chore(lint): report className restyling of components/ui exports (pin…

5a61f50

…gdotgg#12982) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

refactor(web): drop className overrides that repeat the base styles (p…

c26119a

…ingdotgg#12984) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

fix(web): close menus when clicking into the browser tab (pingdotgg#1…

438bf46

…1148)

refactor(web): give Spinner and RefreshIcon a size prop (pingdotgg#12985

b5a0f81

) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

fix(web): keep thread notification tags within the Windows toast limit

3cba3e8

Windows Chromium silently drops renderer notifications when the tag is 73 characters (two UUIDs). Hash the environment+thread pair to a 16-character digest so the toast stays within the platform limit.

cursor Bot force-pushed the cursor/windows-notification-tag-1edc branch from 8198dd9 to 6c333af Compare September 22, 2026 06:30

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Sep 22, 2026

test(web): pin the Windows notification tag digest

edec43b

Assert the hashed tag for a production UUID pair so a change to the digest is an explicit test failure, and document the coverage cases CodeRabbit scores.

cursor Bot force-pushed the cursor/windows-notification-tag-1edc branch from a3c2c45 to edec43b Compare September 22, 2026 06:39

Navigation Menu

fix(web): keep thread notification tags within the Windows toast limit - #6

fix(web): keep thread notification tags within the Windows toast limit#6
macodev00 wants to merge 64 commits into
mainfrom
cursor/windows-notification-tag-1edc

macodev00 commented Sep 20, 2026 •

edited by cursor Bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Conversation

macodev00 commented Sep 20, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

Tests

UI Changes

Checklist

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

macodev00 commented Sep 20, 2026 •

edited by cursor Bot

Loading