Conversation
Picking a machine in the combined Run on / Workspace menu applied the change but left the popover open. Base UI radio items default closeOnClick to false; pass closeOnClick so a pick dismisses the menu, matching the model and traits pickers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pingdotgg#12684.
What Changed
The combined Run on / Workspace menu (
MobileRunContextSelectorinapps/web/src/components/BranchToolbar.tsx) now passescloseOnClickon every radio row: Auto balance, each machine, Current checkout, New worktree, and previous worktree.Why
Picking a machine already updated the composer pill, but the popover stayed open. Base UI
MenuRadioItemdefaultscloseOnClicktofalse. This is the same class of bug as the traits/effort menu (pingdotgg#5879). Environment and workspace picks are single-choice actions, so the menu should dismiss after a click.Wide-layout host/workspace controls are
Selects and already close on pick. Desktop uses the same web renderer, so it is covered. Mobile uses a different picker.UI Changes
Selecting a machine (or workspace mode) in the compact composer Run on menu now closes the popover. No visual redesign.
Checklist