Conversation
starting to running keeps activeCount at 1 and is not attention or terminal, so the 15s Live Activity throttle dropped the running push and the lock screen stayed on Connecting. Exempt observed phase changes from that window. Timestamp and ordering churn stay throttled.
Add JSDoc on the Live Activity throttle helpers and the regression factory so docstring coverage covers the diff. Assert the second queued update carries phase running and status Working.
CodeRabbit docstring coverage stays at 66.67% when JSDoc sits on anonymous it.effect/Effect.gen callbacks. Extract named functions and document the throttle helpers so coverage covers the diff. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit counts nested generator declarations in the test factory, which dropped docstring coverage to 60%. Keep the Effect.gen callback inline like the other cases, and add JSDoc on the neighboring attention helper so the touched functions meet the 80% threshold. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit counted the Option.match onNone/onSome callbacks inside shouldUpdateLiveActivity, holding docstring coverage at 66.67%. Parse the timestamp in a documented helper so the touched functions have JSDoc. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit docstring coverage includes containing functions from diff hunks (parsePreferences, makeLayer). Add JSDoc on those helpers so coverage can clear 80%. Co-authored-by: maco <macodev00@users.noreply.github.com>
Replace the anonymous Effect.gen callback with a module-level generator and bind its input so CodeRabbit can associate JSDoc with the function. Co-authored-by: maco <macodev00@users.noreply.github.com>
Move shouldUpdateLiveActivity and its helpers into a dedicated module so every touched function has JSDoc and CodeRabbit re-analyzes a new file instead of skipping similar docstring-only diffs. Co-authored-by: maco <macodev00@users.noreply.github.com>
Waiting aggregates used to bypass the 15s throttle on any change, including timestamp and ordering churn. Exempt only when attention actually appears or disappears.
A second thread entering waiting_for_input while another was already waiting kept the aggregate attention flag true, so the 15s throttle could drop the update when activeCount stayed the same. Detect newly attention-requiring rows, and keep timestamp and ordering-only waiting updates throttled. Co-authored-by: maco <macodev00@users.noreply.github.com>
github-actions
Bot
added
vouch:trusted
Co-authored-by: maco <macodev00@users.noreply.github.com>
Boolean aggregate attention plus newly waiting rows still missed a waiting thread leaving while another stayed in the throttle window. Compare the waiting-thread set so those transitions publish, while timestamp and ordering churn stay throttled. Co-authored-by: maco <macodev00@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Exempt per-thread phase changes from the 15s Live Activity throttle in
shouldUpdateLiveActivity(infra/relay/src/agentActivity/ApnsDeliveries.ts), next to the existingactiveCount/ attention / newly-terminal exits. Timestamp and ordering churn stay throttled.Add a relay regression: deliver a
startingaggregate, thenrunning~4s later — both must queuelive_activity_update.Named, JSDoc'd helpers so CodeRabbit docstring coverage on the touched functions meets the 80% threshold.
Fixes pingdotgg#12668 (upstream PR pingdotgg#12699)
Why
starting→runningkeepsactiveCountat 1 and is not attention/terminal, so the running update was suppressed inside the 15s window and never retried. The lock screen stayed on Connecting until a later exempt phase or foreground re-register.CodeRabbit docstring coverage was 66.67% (2 of 3 touched functions). JSDoc on anonymous
it.effect/Effect.gencallbacks is not associated with those functions, so the test factory is extracted to named documented functions.UI Changes
No in-app UI change. Lock-screen Live Activity copy can advance from Connecting to Working. Screenshots/video not applicable.
Checklist