Conversation
Settings → Environments is a nested form sheet, so Alert.alert never presented the remove confirm. Always show an in-tree confirm, surface Keychain persist failures, and keep the catalog row if the write fails. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit docstring coverage on the touched functions was 30%. Add one-line TSDoc on each helper, hook, and dialog callback in the diff. Co-authored-by: maco <macodev00@users.noreply.github.com>
FullWindowOverlay does not mark the confirm as modal, so VoiceOver can reach controls behind a destructive dialog. Set accessibilityViewIsModal and dismiss on the VoiceOver escape gesture. Co-authored-by: maco <macodev00@users.noreply.github.com>
github-actions
Bot
added
vouch:trusted
FullWindowOverlay's native container is a sibling of the React root, so accessibilityViewIsModal on the dialog View cannot hide Settings. Mark the overlay container modal and dismiss on the VoiceOver escape gesture. Co-authored-by: maco <macodev00@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/fix-ios-environment-trash-27ef
branch
from
September 22, 2026 06:40
183173c to
31ec14e
Compare
|
@coderabbitai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS Environments trash control did nothing for a saved direct environment. Settings is a nested form sheet, so
Alert.alertnever presented, and a missed list lookup swallowed the tap. A Keychain catalog write failure could also leave the row looking gone until relaunch.Trash now always presents an in-tree confirm (FullWindowOverlay on iOS, even without a list label), removes the catalog target on confirm, and shows an error while keeping the row if SecureStore persist fails.
The confirm overlay root is VoiceOver-modal (
accessibilityViewIsModal) and the two-finger Z escape gesture cancels, so destructive confirm cannot leak focus to controls behind it.This is a fork-only branch for pingdotgg#12012. It is not opened against upstream.
Author: macodev00. Model: Cursor Grok 4.6. Harness: Cursor Cloud.