Conversation
The working pill sat outside the composer overlay, so Android's first content-inset report replaced the seed with composer-only height and the newest streamed lines could not be scrolled into view. Reserve the pill in overlay flow so the measured inset includes it. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit docstring coverage was 33% on the three functions this diff touches. Document ThreadDetailScreen and FloatingWorkingControl so coverage meets the 80% threshold. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit docstring coverage stayed at 66.67% because JSDoc on memo(function ThreadDetailScreen) did not attach to the inner name. Document the named functions this diff touches so coverage can reach 80%. Co-authored-by: maco <macodev00@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pingdotgg#11992 on this fork only. Do not open an upstream PR.
During a running turn on Android, the newest transcript lines sat under the composer and the floating “Working for …” pill and could not be scrolled into view. The pill is absolutely positioned, so the overlay’s
onLayoutnever included it. Android’s firstreportContentInsetthen replaced the seed (which did include pill coverage) with composer-only height.This reserves the pill’s coverage in the composer overlay while the running chrome is shown, so the measured end inset includes it. Settled threads (pill hidden) are unchanged.
Checklist
Model: Cursor Grok 4.6. Harness: Cursor Cloud Agent.