Conversation
Reanimated FadeIn/FadeOut on the expanded editor stole hits inside the nested Settings form sheet, so Label/URL never became first responder and Save/refresh/trash did nothing. Mount the editor in a plain View.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
On iOS, an expanded environment card in Settings → Environments ignored every tap: Label/URL never took focus, and Save/refresh/trash did nothing.
The expanded editor was wrapped in a Reanimated
FadeIn/FadeOutview. That wrapper sits under a parentLinearTransitionand anoverflow-hiddenlist, and on iOS it paints while stealing hits so children never become first responder.The editor now mounts in a plain
Viewwithcollapsable={false}. Expand/collapse still usesLinearTransitionon the row. This does not change the pingdotgg#12012 confirm-alert path.Fixes pingdotgg#12085.
Why
Add Environment on the same nested stack uses the same inputs without
entering/exitingand those fields still focus. The headerPressablestill worked, so the sheet itself was not dead — only the animated expanded block.UI Changes
No visual redesign. Expand no longer fades the editor in; the editor appears with the row height animation.
Could not capture iOS before/after here: this VM has no iOS simulator/device. Verify on an iPhone: Settings → Environments → expand a saved environment → Label focuses and types; Save/refresh/trash receive presses.
Checklist