Conversation
When the default Codex text-generation selection is unusable, fall back to the enabled instance's defaultModelSelection or custom model instead of a hardcoded slug like claude-haiku-4-5. Co-authored-by: maco <macodev00@users.noreply.github.com>
Use the same inline settings.json strings as the rest of the suite so typecheck does not flag JSON.stringify or unbranded instance ids. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit required 80% docstring coverage on functions in this diff. Co-authored-by: maco <macodev00@users.noreply.github.com>
Extract the enabled-instance predicate so the last undocumented callback in the docstring coverage set has a one-line TSDoc. Co-authored-by: maco <macodev00@users.noreply.github.com>
runClaudeJson preferred non-empty stderr on CLI failure, so credential wrapper notices hid stdout api_error_status and result. Prefer the structured stdout API error when present.
HTTP status codes are finite, so decode api_error_status with Schema.Finite instead of Schema.Number.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
When one-shot text generation (commit / PR / branch / title) has to fall back because the stored
textGenerationModelSelectioninstance is unusable, it now uses the enabled instance's configured model:defaultModelSelectionwhen it belongs to that instancecustomModels(including the legacy per-kind bucket)Why
With default settings, decode still materializes Codex +
gpt-5.6-luna. If that instance is disabled, fallback previously rewrote the selection toclaude-haiku-4-5even when the Claude instance had a working custom / default model. Guardrailed backends that refuse Anthropic slugs then fail every commit/title spawn.Fixes pingdotgg#12651
Checklist