Conversation
Reanimated entering/layout wrappers on the expanded environment editor stole hits in the Settings form sheet, so Label/URL never focused and Save/refresh/trash never ran. Mount the editor in a plain View instead. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit docstring coverage was 0% on the one function this PR touches. Co-authored-by: maco <macodev00@users.noreply.github.com>
CodeRabbit docstring coverage was 50% on two named functions this PR touches. ConnectionEnvironmentRow already had a docstring. Co-authored-by: maco <macodev00@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Stop wrapping the expanded environment editor in Reanimated
FadeIn/FadeOut/LinearTransition. Mount it in a plainViewwithcollapsable={false}so Label, URL, Save, refresh, and trash can receive taps and focus on iOS.Why
On iOS, Settings → Environments → expand a saved direct environment painted the card (Label, URL, Save, refresh, trash) then ignored every tap. Fields never focused; Save/refresh/trash did nothing. Expand/collapse still worked because that is the header
Pressable.The expanded block sat under Reanimated
entering={FadeIn}/exiting={FadeOut}with a parentlayout={LinearTransition}inside a nested form sheet. That wrapper paints but steals hits, so children never become first responder. Add Environment on the same stack uses the same inputs without those animations and still works.Fixes pingdotgg#12085. Does not change the pingdotgg#12012
Alert.alertconfirm path.No iOS simulator in this environment, so there are no before/after recordings. The change is the hit-testing wrapper only.
Checklist