Skip to content

fix(ci): pin isolated-kit gradle version to prevent 6.0.0-rc.1 pull#714

Merged
jamesnrokt merged 1 commit into
mainfrom
fix/pin-isolated-kit-version-rc1
May 27, 2026
Merged

fix(ci): pin isolated-kit gradle version to prevent 6.0.0-rc.1 pull#714
jamesnrokt merged 1 commit into
mainfrom
fix/pin-isolated-kit-version-rc1

Conversation

@jamesnrokt
Copy link
Copy Markdown
Collaborator

Summary

  • Pin the standalone urbanairship-kit build invocations in daily.yml and pull-request.yml to the SDK version we're currently building, so they no longer resolve + to com.mparticle:android-kit-plugin:6.0.0-rc.1 on Maven Central.
  • Mirrors the pattern already used by release.yml's Sonatype Release job.

Why

The 2026-05-27 release run failed with two distinct errors, both in the urbanairship-kit isolated steps:

Run regression / Lint Checks → Run Isolated Kit Lint (urbanairship-kit)
  e: UrbanAirshipKit.kt:31:20 Unresolved reference 'AttributeListener'.
  e: 8× "overrides nothing"

Run regression / Update Kits → Test Isolated Kits (urbanairship-kit)
  Task 'publishReleaseLocal' not found in root project 'android-urbanairship-kit'.

Root cause: the kit's standalone build.gradle defaults project.version = '+'. With 6.0.0-rc.1 published to Maven Central on 2026-05-22, + resolves to the RC, which renamed KitIntegration.AttributeListenerModifyIdentityListener and replaced the kit-plugin's task layout. The fix is to pass -Pversion=<sdk-version> so the kit resolves the freshly-published mavenLocal artifact instead.

Every PR's Kit Compatibility Test has been silently red since 2026-05-22 for the same reason.

Companion changes

Defense-in-depth pin on the kit's standalone project.version:

External-consumer fixes for #710:

Test plan

  • Trigger the Release SDK workflow (dry run). Lint Checks, Kotlin Lint Checks, and Update Kits should all pass through the urbanairship-kit isolated step.
  • Open a no-op PR to verify Kit Compatibility Test is green.

🤖 Generated with Claude Code

The isolated urbanairship-kit lint/test steps in daily.yml and the
kit-compatibility test in pull-request.yml run `./gradlew` from inside
the kit dir without `-Pversion=...`. The kit's standalone build.gradle
defaults `project.version = '+'`, so its `com.mparticle:android-kit-plugin`
dependency resolves to the highest version on Maven Central — now
`6.0.0-rc.1` (published 2026-05-22), which renamed/removed kit-base
symbols and broke the kit's compile.

Mirror the pattern already used in the Sonatype Release job: extract the
SDK version via `./gradlew -q properties` and pass it as `-Pversion=...`
to every standalone kit invocation, so it resolves the freshly-published
mavenLocal artifact instead of the RC.

Affected steps:
- lint-checks → Run Isolated Kit Lint (urbanairship-kit)
- kotlin-lint-checks → Run Isolated Kit Kotlin Lint (urbanairship-kit)
- update-kits → Test Isolated Kits (urbanairship-kit)
- kit-compatibility-test → Run Isolated Kit Compatibility Tests (urbanairship-kit)

The companion defensive fix in mparticle-android-integration-urbanairship
pins the kit's standalone `project.version` to `[5.0,6.0)`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jamesnrokt jamesnrokt requested a review from a team as a code owner May 27, 2026 19:51
@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Workflow-only changes; no runtime SDK behavior, only fixes CI dependency resolution for isolated kit jobs.

Overview
CI now reads the root SDK version from Gradle and passes -Pversion=<that version> into standalone urbanairship-kit runs in daily.yml (lint, ktlint, update-kits) and pull-request.yml (kit compatibility).

That stops isolated kit builds from using the kit default +, which had been resolving to 6.0.0-rc.1 on Maven Central and breaking lint/tests. Isolated steps align with the in-repo / mavenLocal SDK being built in the same job.

Reviewed by Cursor Bugbot for commit 1b9d339. Bugbot is set up for automated code reviews on this repo. Configure here.

@sonarqubecloud
Copy link
Copy Markdown

@jamesnrokt jamesnrokt merged commit eff10ea into main May 27, 2026
16 of 18 checks passed
@jamesnrokt jamesnrokt deleted the fix/pin-isolated-kit-version-rc1 branch May 27, 2026 21:09
mparticle-automation added a commit that referenced this pull request May 27, 2026
## [5.79.1](v5.79.0...v5.79.1) (2026-05-27)

### Bug Fixes

* **ci:** pin isolated-kit gradle version to prevent 6.0.0-rc.1 pull ([#714](#714)) ([eff10ea](eff10ea))

### Updates & Maintenance

* bump trunk-io/trunk-action from 1.2.4 to 1.3.1 ([#705](#705)) ([f4ceca7](f4ceca7))
* Update submodules ([e435979](e435979))
@mparticle-automation
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.79.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants