Completely fake out the network for simple tests - #9636
Merged
Conversation
This covers the happy path of OkHttp + MockWebServer with no TLS. There's nothing too exciting here, other than using Okio's inMemorySocketPair instead of a proper TCP socket for data. In a follow-up PR I intend to layer on TLS including all the exotic options like ECH and handshake failures. I won't do any actual cryptography, just like how this doesn't do any actual TCP packets.
yschimke
approved these changes
Aug 7, 2026
| * limitations under the License. | ||
| */ | ||
| package okhttp3 | ||
| package okhttp3.sockets |
| * A complete in-memory socket system, suitable for testing OkHttp without using any operating | ||
| * system TCP sockets. | ||
| */ | ||
| class FakeNetwork { |
Collaborator
There was a problem hiding this comment.
Just having PTSD flashbacks to my falled mocksocket attempt :)
Collaborator
Author
There was a problem hiding this comment.
This was a bit less ambitious?
|
|
||
| val timeout = Timeout() | ||
| .deadline(connectTimeoutMillis, TimeUnit.MILLISECONDS) | ||
| boundServer.enqueue(timeout, attempt) |
| import org.junit.jupiter.api.extension.RegisterExtension | ||
|
|
||
| open class FakeNetworkOkHttpTest { | ||
| private val network = FakeNetwork() |
…work.kt Co-authored-by: Yuri Schimke <yuri@schimke.ee>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers the happy path of OkHttp + MockWebServer with no TLS.
There's nothing too exciting here, other than using Okio's inMemorySocketPair instead of a proper TCP socket for data.
In a follow-up PR I intend to layer on TLS including all the exotic options like ECH and handshake failures. I won't do any actual cryptography, just like how this doesn't do any actual TCP packets.