fix: guard the suggestion index in shell completion - #308
Merged
lucassabreu merged 1 commit intoSep 17, 2026
Merged
Conversation
nikosavola
commented
Sep 17, 2026
nikosavola
commented
Contributor
- len(args) == len(fns) passed the guard and then indexed past the end, panicking inside __complete
- len(args) == len(fns) passed the guard and then indexed past the end, panicking inside __complete Co-Authored-By: DeepSeek V4.1 Flash <noreply@deepseek.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 32.36% 32.46% +0.09%
==========================================
Files 141 141
Lines 9016 9016
==========================================
+ Hits 2918 2927 +9
+ Misses 5984 5974 -10
- Partials 114 115 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lucassabreu
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.