lunatik: run the kernel make from the build dir, drop KBUILD_AFLAGS - #18
Open
marcelstanley wants to merge 1 commit into
Open
lunatik: run the kernel make from the build dir, drop KBUILD_AFLAGS#18marcelstanley wants to merge 1 commit into
marcelstanley wants to merge 1 commit into
Conversation
Lunatik's Kbuild locates the klibc and lua headers through ${PWD}, so
the feed compensated for the wrong cwd by repeating the -I flags in
EXTRA_CFLAGS and KBUILD_AFLAGS. A KBUILD_AFLAGS given on the command
line replaces the kernel's default (-D__ASSEMBLY__ -fno-PIE); without
__ASSEMBLY__, klibc's setjmp.S is preprocessed through the C parts of
compiler_types.h and fails on __has_attribute with kernel 6.6.
Running the kernel make from PKG_BUILD_DIR lets Kbuild's own
asflags-y/ccflags-y apply, which also retires the feed's private
KLIBC_ARCH mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lunatik's Kbuild locates the klibc and lua headers through ${PWD}, so the feed compensated for the wrong cwd by repeating the -I flags in EXTRA_CFLAGS and KBUILD_AFLAGS. A KBUILD_AFLAGS given on the command line replaces the kernel's default (-D__ASSEMBLY__ -fno-PIE); without ASSEMBLY, klibc's setjmp.S is preprocessed through the C parts of compiler_types.h and fails on __has_attribute with kernel 6.6.
Running the kernel make from PKG_BUILD_DIR lets Kbuild's own asflags-y/ccflags-y apply, which also retires the feed's private KLIBC_ARCH mapping.