-
Notifications
You must be signed in to change notification settings - Fork 12
fix(cli): exit the server when the MCP client closes stdin #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { EventEmitter } from "events"; | ||
|
|
||
| import { exitWhenClientDisconnects } from "./lifecycle"; | ||
|
|
||
| describe("exitWhenClientDisconnects", () => { | ||
| let exitSpy: jest.SpyInstance; | ||
|
|
||
| beforeEach(() => { | ||
| jest.useFakeTimers(); | ||
| exitSpy = jest.spyOn(process, "exit").mockImplementation((() => undefined) as never); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| exitSpy.mockRestore(); | ||
| jest.useRealTimers(); | ||
| }); | ||
|
|
||
| it("exits with code 0 after stdin ends", () => { | ||
| const stdin = new EventEmitter(); | ||
| exitWhenClientDisconnects(stdin); | ||
|
|
||
| stdin.emit("end"); | ||
|
|
||
| expect(exitSpy).not.toHaveBeenCalled(); | ||
| jest.runAllTimers(); | ||
| expect(exitSpy).toHaveBeenCalledWith(0); | ||
| }); | ||
|
|
||
| it("exits once when both end and close fire", () => { | ||
| const stdin = new EventEmitter(); | ||
| exitWhenClientDisconnects(stdin); | ||
|
|
||
| stdin.emit("end"); | ||
| stdin.emit("close"); | ||
| jest.runAllTimers(); | ||
|
|
||
| expect(exitSpy).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| it("stays alive while the client is connected", () => { | ||
| const stdin = new EventEmitter(); | ||
| exitWhenClientDisconnects(stdin); | ||
|
|
||
| jest.runAllTimers(); | ||
|
|
||
| expect(exitSpy).not.toHaveBeenCalled(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /** | ||
| * MCP clients signal shutdown over stdio by closing the server's stdin. | ||
| * The bundled transport only listens for "data", so without this watcher | ||
| * the process outlives its client: `docker run --rm` never removes the | ||
| * container and npx-launched processes linger on the host. | ||
| */ | ||
|
|
||
| // Must exceed the PostHog flushInterval in core/analytics.ts (1000 ms) so | ||
| // telemetry from the final tool call is sent before the process exits. | ||
| const TELEMETRY_FLUSH_GRACE_MS = 1250; | ||
|
|
||
| export function exitWhenClientDisconnects(stdin: NodeJS.EventEmitter = process.stdin): void { | ||
| let exitScheduled = false; | ||
|
|
||
| const scheduleExit = () => { | ||
| if (exitScheduled) return; | ||
| exitScheduled = true; | ||
| setTimeout(() => process.exit(0), TELEMETRY_FLUSH_GRACE_MS); | ||
| }; | ||
|
|
||
| stdin.once("end", scheduleExit); | ||
| stdin.once("close", scheduleExit); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.