fix(rds): split schema-qualified identifiers in query builders#249
Merged
Conversation
select() and the other @aws-appsync/utils/rds query builders quoted the
entire raw identifier as a single unit, so select({table: "domain.item"})
emitted SELECT * FROM "domain.item" -- one literal relation Postgres looks
up verbatim, which doesn't exist. The same defect hit column-qualified
names (columns: ['persons.name'] -> "persons.name").
Add a quoteIdentifier() helper that splits qualified identifiers on `.`
and quotes each segment, matching AWS AppSync ("domain"."item",
"persons"."name"), and route every identifier-quoting site (table/column
names across select/insert/update/remove/where/orderBy/returning) through
it.
Tests assert parity against snapshots captured from real AWS via
test:aws; unqualified names remain quoted as a single segment.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select() and the other
@aws-appsync/utils/rdsquery builders quoted the entire raw identifier as a single unit, soselect({table: "domain.item"})emittedSELECT * FROM "domain.item"; one literal relation Postgres looks up verbatim, which doesn't exist. The same defect hit column-qualified names (columns: ['persons.name']->"persons.name").Add a
quoteIdentifier()helper that splits qualified identifiers on.and quotes each segment, matching AWS AppSync (ù"domain"."item","persons"."name"`), and route every identifier-quoting site (table/column names across select/insert/update/remove/where/orderBy/returning) through it.Tests assert parity against snapshots captured from real AWS via
test:aws; unqualified names remain quoted as a single segment.I manually tested the fix with a reproduction sample and can attest that this fixed it in LocalStack as well.
Done with Claude Code and a bit of manual steering
towards AWS-1011