smite-scenarios: log messages in name(type) format - #194
Open
ekzyis wants to merge 2 commits into
Open
Conversation
erickcestari
suggested changes
Aug 11, 2026
erickcestari
left a comment
erickcestari
left a comment
Contributor
There was a problem hiding this comment.
I like the idea to make the logs more self-describing
Concept ACK 667aae8
Collaborator
|
Concept ACK. I think a much simpler way is to implement the |
ekzyis
force-pushed
the
log-messages-in-name-type-format
branch
from
August 11, 2026 22:07
667aae8 to
a56bfc7
Compare
Contributor
Author
|
addressed feedback in a56bfc7:
|
ekzyis
force-pushed
the
log-messages-in-name-type-format
branch
from
August 12, 2026 12:43
a56bfc7 to
33a0f32
Compare
Contributor
Author
morehouse
reviewed
Aug 12, 2026
Collaborator
|
We should also be able to get rid of the |
erickcestari
left a comment
erickcestari
left a comment
Contributor
There was a problem hiding this comment.
Probably a follow-up PR, but another thing that might be useful for debugging is to log the warning and error data field as ASCII.
ekzyis
force-pushed
the
log-messages-in-name-type-format
branch
from
August 12, 2026 21:57
33a0f32 to
b038b4e
Compare
ekzyis
marked this pull request as draft
August 12, 2026 21:58
We want logs and errors to be self-describing, so we introduce a new type `MessageType` whose `Display` renders as `name(type)`, e.g. `open_channel(32)`. The existing `bolt::msg_type` u16 constants are folded into it.
ekzyis
force-pushed
the
log-messages-in-name-type-format
branch
from
August 15, 2026 00:37
b038b4e to
33ea0b2
Compare
ekzyis
marked this pull request as ready for review
August 15, 2026 00:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this quite useful. This changes the logs like this:
and
WDYT? Concept ACK?