fix: guard vote_last_response against None state#3862
Open
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Open
fix: guard vote_last_response against None state#3862Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Conversation
After clear_history resets state to None, a rapid click on a vote button before Gradio updates the UI sends a request with state=None, causing AttributeError on state.dict(). Return early when state is None. Fixes lm-sys#3787
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
vote_last_responsecallsstate.dict()without checking ifstateisNone.Root cause: After
clear_historyresetsstatetoNoneand returns disabled buttons, there is a small window before Gradio's UI update reaches the client. A rapid vote-button click during this window sends a request withstate=None, causingAttributeError: 'NoneType' object has no attribute 'dict'and crashing the server.Why the fix is correct: The intended behavior when state is absent is to do nothing — the vote is meaningless without a conversation to associate it with. Returning early from
vote_last_responsewhenstate is Nonemirrors the existing null-state guard inadd_textand prevents the crash without affecting normal operation.Closes #3787