CI improvements#628
Open
tavip wants to merge 4 commits intolkl:masterfrom
Open
Conversation
Use a relative junit path to store test results so that it works for both Linux and Windows checks. Before this patch test results were not saved for Windows. Signed-off-by: Octavian Purdila <tavip@google.com>
tavip
force-pushed
the
fix-win-test-artifacts
branch
from
fae26e5 to
e5e63fc
Compare
Member
|
thanks, I wasn't aware of the missing report files on windows. |
tavip
force-pushed
the
fix-win-test-artifacts
branch
from
e5e63fc to
f6c9a8b
Compare
ddiss
reviewed
Apr 28, 2026
| permissions: | ||
| pull-requests: write | ||
| checks: write | ||
| contents: read |
There was a problem hiding this comment.
It might be worth annotating these new permissions. It appears that detailed_summary comments require the pull-requests: write permission, while actual source changes should be remain blocked (contents: read).
Member
Author
There was a problem hiding this comment.
Added comments in the new workflow.
tavip
force-pushed
the
fix-win-test-artifacts
branch
from
f6c9a8b to
3b4f542
Compare
Github checks uses classname to create the test hierarchy. Signed-off-by: Octavian Purdila <tavip@google.com>
tavip
force-pushed
the
fix-win-test-artifacts
branch
from
3b4f542 to
653e512
Compare
Add test reporter workflow to show tests results directly in Github as checks. New workflow is needed to allow checks to be published for PRs from forked repositories. Signed-off-by: Octavian Purdila <tavip@google.com>
A dummy boot test has been added to propagate the suite name for valgrind checks, but because it has no name it can confuse Github checks. Fixes: 6a5eaa0 ("lkl: refine valgrind tests and report") Signed-off-by: Octavian Purdila <tavip@google.com>
tavip
force-pushed
the
fix-win-test-artifacts
branch
from
653e512 to
f257a11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where test results are not saved on Windows. Also show test results details directly on the Gtihub page.