Conditional uploads and ranged downloads on every backend - #34
Open
theomonnom wants to merge 2 commits into
Open
theomonnom wants to merge 2 commits into
theomonnom wants to merge 2 commits into
Conversation
ConditionalUploader adds UploadDataIfAbsent and UploadFileIfAbsent: the object is written only when none is there, with S3's If-None-Match on the put and on the multipart completion, and O_EXCL on local storage. RangeDownloader adds DownloadRange for part of an object. Both take a context. ErrNotFound and ErrObjectExists are wrapped into the backend errors for those outcomes, so callers decide with errors.Is. S3 and local implement both; the other backends are unchanged.
|
Théo Monnom seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
UploadDataIfAbsent, UploadFileIfAbsent and DownloadRange join Storage rather than sitting in optional interfaces two backends offered: S3 uses If-None-Match, GCS a DoesNotExist precondition, Azure an ETag condition, OSS forbid-overwrite, local storage O_EXCL. Every backend wraps its not-found and already-exists outcomes in ErrNotFound and ErrObjectExists. ConditionalUploader and RangeDownloader remain as the named subsets.
theomonnom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UploadDataIfAbsent,UploadFileIfAbsent,DownloadRange(ctx, ...)onStorage, implemented by every backend: S3If-None-Match, GCSDoesNotExistprecondition, Azure ETag condition, OSS forbid-overwrite, localO_EXCLErrNotFound,ErrObjectExistswrapped into every backend's errors (404, 412, 409 as each service reports them), so callers useerrors.IsConditionalUploaderandRangeDownloaderremain as the named subsetscontext.Context; the older ones keep their shapeS3_*env (passes on MinIO); GCS, Azure and OSS compile against their SDKs and follow the same suite once their env is set