TEL-1048 - Ensure RoomId set for inbound calls when caller hangs up - #848
Merged
ChelseaBradbury merged 5 commits intoSep 15, 2026
Merged
Conversation
…s (mirror post-waitSubscribe state update) + improve log message
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hechen-eng
requested changes
Sep 15, 2026
| if r := c.lkRoom.Room(); r != nil { | ||
| info.RoomId = r.SID() | ||
| info.RoomName = r.Name() | ||
| info.ParticipantAttributes = r.LocalParticipant.Attributes() // clones |
Contributor
There was a problem hiding this comment.
I am not sure we want this 🤔
We do room.LocalParticipant.SetAttributes(partConf.Attributes) in Connect, but it's not guaranteed it'll be there in time. Considering this update happens right after joinRoom, it's possible it's not updated. As a result, it may wipe out what's been set earlier. Given the PR is just for roomId, I would suggest to just drop this line.
Suggested change
| info.ParticipantAttributes = r.LocalParticipant.Attributes() // clones |
hechen-eng
approved these changes
Sep 15, 2026
ChelseaBradbury
deleted the
chelsea/TEL-1048-ensure-room-session-id-set
branch
September 15, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a caller hangs up during
waitSubscribe(), the call doesn't get a RoomId, even though the room has already been created and joined. Downstream, this causes the dashboard to show an empty session / room name for the call on the call overview, although the room info is still available in the event payloads.This change sets the RoomId as soon as the room is joined, which should fix this case.