chore: use LiveKitWebRTC#94
Draft
griffithcaleb wants to merge 1 commit into
Draft
Conversation
Author
|
Believe CI is failing becase consuming test app needs to declare livekit podspec repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch iOS dependency from WebRTC-SDK to LiveKitWebRTC to resolve CocoaPods framework conflicts
Problem
When using
livekit-react-native-webrtcalongside other WebRTC-based SDKspod installfails with:Both
WebRTC-SDKandJitsiWebRTCvendor a framework namedwebrtc.xcframework, and CocoaPods refuses to integrate two frameworks with the same filename into the same target.Related: livekit/livekit#2809
Solution
Switch the iOS CocoaPods dependency from
WebRTC-SDKtoLiveKitWebRTC— LiveKit's own repackaged WebRTC build fromlivekit/webrtc-xcframework. This is the same WebRTC codebase (same version144.7559.10) but:LiveKitWebRTC.xcframework(no filename collision)LK(e.g.,RTCPeerConnection→LKRTCPeerConnection, no linker-level collisions)This matches what
client-sdk-swiftalready does — it depends onLiveKitWebRTC, notWebRTC-SDK.Changes
WebRTC-SDK→LiveKitWebRTCdependencyios/ObjC sources:#import <WebRTC/...>→#import <LiveKitWebRTC/...>#import <LiveKitWebRTC/WebRTC.h>→#import <LiveKitWebRTC/LiveKitWebRTC.h>(umbrella header renamed)LK(e.g.,RTCPeerConnection→LKRTCPeerConnection)RTCVideoView,RTCVideoViewManager,RTCVideoViewObjectFit) to maintain JS bridge compatibilityNo JS-side changes required
The native module name (
WebRTCModule) and native view name (RTCVideoView) are unchanged, so no changes to the TypeScript/JavaScript layer are needed.