fix(server-sdk): remove legacy node:crypto fallbacks to support edge/workers/isolate runtimes - #704
Open
intrdx wants to merge 4 commits into
Open
fix(server-sdk): remove legacy node:crypto fallbacks to support edge/workers/isolate runtimes#704intrdx wants to merge 4 commits into
intrdx wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 9f99aa7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
await import('node:crypto')fallbacks inlivekit-server-sdk/src/crypto/uuid.tsandlivekit-server-sdk/src/crypto/digest.tsengines.nodeto>=19from>=18(global Web Crypto support)Workers/V8/Edge runtime bundlers fail on a dead-branch
import('node:crypto')even when Web Crypto is available at runtime.Background
import('node:crypto')in digest for Node 18. This was 2 years ago and legacy now.This restores a Web-Crypto-only module graph for those helpers so bundlers that disallow Node builtins can use the
livekit-server-sdk.Refs: #121 #122 #349