close audio streams after unsubscribe, bump FFI to 0.12.68 - #701
Merged
Conversation
🦋 Changeset detectedLatest commit: 5ff6574 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
davidzhao
changed the title
davidzhao
commented
Jul 28, 2026
| this.controller.enqueue(frame); | ||
| break; | ||
| case 'eos': | ||
| FfiClient.instance.off(FfiClientEvent.FfiEvent, this.onEvent); |
Member
Author
There was a problem hiding this comment.
refactored in teardown
paulwe
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we are still pulling in a version of the ffi prior to resume/reconnect fixes. updating the pointers to pull in these fixes.
also cleaning up the stream when unsubscribed before eos, and relaxed a few conditions to make tests less flaky