chore(deps): pin @livekit/protocol to livekit-client's version - #1459
Merged
Merged
Conversation
1egoman
requested review from
lukasIO and
thomasyuill-livekit
as code owners
September 25, 2026 14:45
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
livekit-client 2.22.3 pins @livekit/protocol to exactly 1.50.4, but Renovate had bumped the workspace catalog ahead of it (1.51.0, 1.52.0, then 1.52.1), leaving multiple protocol copies in the tree. Move the catalog back to 1.50.4 and stop Renovate from bumping @livekit/protocol on its own, so it only moves together with livekit-client. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1egoman
force-pushed
the
pin-protocol-to-livekit-client
branch
from
September 25, 2026 14:51
251b886 to
c65140e
Compare
Contributor
size-limit report 📦
|
lukasIO
approved these changes
Sep 25, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This comment in
pnpm-workspace.yamlsays the catalog's@livekit/protocolversion has to match the exact versionlivekit-clientpins. That way the workspace andlivekit-clientshare one copy of the protobuf types. With two copies, types likeTrackInfostop being structurally compatible and the build breaks.Renovate has been bumping
@livekit/protocolseparately fromlivekit-client. #1429 moved it to 1.51.0, #1446 to 1.52.0, and #1458 to 1.52.1. Meanwhile the latestlivekit-client(2.22.3) still pins 1.50.4. Somainalready breaks the rule and has several copies of protocol in the tree. Nothing has failed yet only because the types we use across the boundary (TrackInfo,ParticipantPermission) haven't changed between those versions. That will stop being true the next time protocol changes one of them.Given this,
livekit-clientand@livekit/protocolneed to be updated in sync.@livekit/protocolshould only be bumped in the same change that bumpslivekit-client, and it should be set to whatever version that release pins.Changes
pnpm-workspace.yaml: set the catalog back to1.50.4to matchlivekit-client@2.22.3, and note in the comment that the bump is done by hand.renovate.json: add a rule that turns off Renovate updates for@livekit/protocol, so it can't drift ahead oflivekit-clientagain.livekit-clientitself still gets Renovate PRs. Whoever lands one should update the catalog's protocol version to match in the same PR.pnpm-lock.yaml: workspace importers now resolve@livekit/protocol@1.50.4, the same copylivekit-clientuses.@livekit/krisp-noise-filterstill resolves its own^1.45.4range to 1.51.0 as a transitive dependency. It shares that copy withlivekit-server-sdk. Its types don't reach our code, so that doesn't matter here.Testing
pnpm build --force,pnpm test --force,pnpm api:check --forceandpnpm format:checkall pass locally.