Conversation
fatihcvs
requested review from
1egoman,
lukasIO and
thomasyuill-livekit
as code owners
September 19, 2026 23:53
|
@fatihcvs is attempting to deploy a commit to the LiveKit Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 43bc945 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupDataMessageHandler().send()throws before publishing if nobody subscribed toisSendingObservable, because its stored subscriber is still undefined. Subscribing more than once also overwrites that subscriber, so only the latest observer sees sending-state changes.Use a
BehaviorSubjectfor the shared sending state and expose it as anObservable<boolean>. Sending no longer requires a state subscription, all observers receive updates, and a subscriber joining during a send receives the current state. The existing publish-error propagation andfinallyreset are preserved.Validation:
RoomwithpublishDatastubbed to control completion/rejection; no server connection is made.pnpm build:react, core lint (14 existing warnings),pnpm format:check, and React API check pass. The generated sending-state return type remainsObservable<boolean>.Includes a core patch changeset. Developed and verified with OpenAI Codex assistance.