Repository navigation
fix(aws): don't retry Polly 4xx errors such as InvalidSsmlException - #7969
Open
omChauhanDev wants to merge 1 commit into
Open
omChauhanDev wants to merge 1 commit into
omChauhanDev wants to merge 1 commit into
Conversation
Polly 4xx rejections now raise APIStatusError with the status code and request id instead of a retryable APIConnectionError. Throttling (a 400 ThrottlingException), 408, 429, 5xx and errors that don't come from SynthesizeSpeech keep the old behaviour.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
longcw
approved these changes
Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ChunkedStream._runinaws/tts.pywraps every botocoreClientErrorinAPIConnectionError(), which is retryable by default. So a request Polly rejects outright, such as anInvalidSsmlException, aTextLengthExceededExceptionor a 403 for bad credentials, is sent again untilmax_retryruns out. With the default connect options that is four identical requests and about 4 seconds of backoff before it fails, and it fails as a connection error without Polly's status code or request id.Changes
_runnow catchesClientError, and when Polly rejects the request with a 4xx it raises anAPIStatusErrorwith the status code and request id, so it isn't retried. Throttling (Polly sends it as a 400ThrottlingException), 408, 429, 5xx andClientErrors that don't come fromSynthesizeSpeech, such as STS while botocore refreshes credentials, still raiseAPIConnectionErroras before.