Repository navigation
fix(gradium): report the configured model name from TTS.model and STT.model - #7814
Merged
Merged
Conversation
|
|
hhugo-gradium
force-pushed
the
fix/gradium-model-name
branch
from
October 14, 2026 11:34
fc908b7 to
dc0cdd5
Compare
hhugo-gradium
marked this pull request as ready for review
October 14, 2026 11:36
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced Oct 14, 2026
Contributor
Author
|
cc @longcw |
longcw
approved these changes
Oct 20, 2026
Contributor
Author
|
@longcw, I think the ci failure is unrelated |
….model Both properties returned the literal "unknown", so TTS and STT metrics and traces carried no model name even though `model_name` is always known. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
hhugo-gradium
force-pushed
the
fix/gradium-model-name
branch
from
October 20, 2026 16:14
dc0cdd5 to
a11754f
Compare
longcw
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TTS.modelandSTT.modelreturned the literal"unknown", so TTS and STT metrics and traces carried no model name even thoughmodel_nameis always known at construction. Both now return the configuredmodel_name.Testing
tests/test_plugin_gradium_model_name.py(unit category).ruff,ruff format --checkandmypy --strictclean on the plugin.Split out of #7672.
🤖 Generated with Claude Code