Repository navigation
fix(stt): anchor transcript timestamps on the session input start #7795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+515
−25
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7551e17
fix(stt): anchor transcript timestamps on the session input start
chenghao-mou 04e8f6d
fix(stt): anchor the offset on consumed audio and keep custom nodes f…
chenghao-mou 57b9964
fix(stt): stamp resampled frames with the capture time of their audio
chenghao-mou 57d12ab
fix(stt): keep capture gaps when stamping resampled frames
chenghao-mou ead308d
fix(stt): anchor the offset on push and drop the resampler span tracking
chenghao-mou abe2a94
docs(stt): state the timestamp contract on stt_node and rename the of…
chenghao-mou 025dee8
refactor(stt): keep one offset helper and write the setter inline
chenghao-mou faff357
refactor(stt): rename the offset helper to _capture_start_offset_from
chenghao-mou dc10a8d
refactor(stt): seed the fallback leg with a walrus
chenghao-mou 8253d79
chore(stt): assign the queued-frame TODO
chenghao-mou 6cfb478
refactor(stt): keep the stream timeline in the input channel
chenghao-mou 728e81b
test(voice): restore the input_started_at stamping check
chenghao-mou 5082abe
fix(stt): anchor queued audio on its oldest capture across input pauses
chenghao-mou 69a151c
fix(stt): seed a fallback leg that starts before the timeline
chenghao-mou 3fd2c0e
test(stt): describe the first-audio anchor for custom nodes
chenghao-mou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if a plugin reconnect inside
_run, e.g. for theupdate_options, it restarts the provider's clock but nothing callsrestart_provider_clock, would this be a problem?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. I am adding them in the #7796 so each plugin resets when it reconnects internally