Conversation
Contributor
There was a problem hiding this comment.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize Mistral error handling across LLM, STT, and TTS while preserving provider error details and retry semantics.
Motivation
With an invalid LLM model such as
foo, Mistral returns HTTP 400 with error code 3003.The LLM plugin previously handled Mistral's
SDKErroras a generic exception, turning this non-retryable API response into a retryableAPIConnectionError. One user turn therefore produced four misleadingConnection errorevents, theinitial request plus three retries.
Changes
SDKErrorandHTTPValidationErrorintoAPIStatusErroracross LLM, STT, and TTS.x-request-id.asyncio/httpxtimeouts intoAPITimeoutError.Ordinary 4xx responses are now non-retryable, while transient statuses continue to follow
APIConnectOptions.Tests
APIStatusError.