fix(anthropic): disable vendor SDK retries by default - #6604
Draft
axelray-dev wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6603.
livekit-plugins-anthropicwas buildinganthropic.AsyncClientwithoutmax_retries, so the SDK default of 2 internal retries stacked on top of frameworkconn_options.max_retry. That made wall-clock time exceedconn_options.timeout(especially with FallbackAdapter).OpenAI plugin already defaults vendor client retries to 0. This PR matches that for Anthropic.
Changes
max_retries=0by default when constructinganthropic.AsyncClientin the Anthropic LLM plugin.max_retriesconstructor arg for callers who want a different vendor-client policy.max_retries == 0.client=injection is unchanged (caller owns that client).Verification
ruff format/ruff checkon touched filespytest tests/test_plugin_anthropic.py(8 passed)Backwards compatibility
Default behavior for the constructed client changes from SDK default (2) to 0 so retries are owned by the framework only. Callers who pass their own
client=are unaffected. Callers who want SDK retries can passmax_retries=....