fix(evals): avoid overriding judge reasoning - #6566
Merged
Merged
Conversation
inickt
marked this pull request as ready for review
July 27, 2026 14:54
tinalenguyen
left a comment
Member
There was a problem hiding this comment.
thank you for the PR, this change makes sense. i think maybe we should set the default reasoning for inference GPT 5 models to none before applying this change so the judges don't suddenly start with medium effort. i can make that PR
tinalenguyen
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning_effort="none"option.Why
The judge accepts any LLM, but
reasoning_effortis specific to Chat Completions. Passing it to an OpenAI Responses client fails because Responses uses thereasoningobject instead.Explicitly configured reasoning options continue to apply. LLMs without an explicit configuration will now use their provider or model default rather than having the judge force reasoning off.
Testing