chore: update pnpm and ensure builds continue to work#2096
Conversation
|
| allowBuilds: | ||
| '@google/genai': true | ||
| '@livekit/local-inference': true | ||
| esbuild: true | ||
| onnxruntime-node: true | ||
| protobufjs: true | ||
| sharp: true |
There was a problem hiding this comment.
🔴 Dependency install scripts are silently disabled after the package manager upgrade
The list of dependencies whose install steps should run is written under an unrecognized setting name (allowBuilds at pnpm-workspace.yaml:28) instead of the setting the tool actually reads, so none of the listed dependencies' install steps run.
Impact: Native packages like sharp and onnxruntime-node never get built during install, which can make installs or agent runs fail at runtime.
Wrong pnpm setting key and value format
Starting with pnpm v11, packages with build/postinstall scripts are blocked by default unless explicitly allowlisted via the onlyBuiltDependencies setting, which takes a YAML list of package names:
onlyBuiltDependencies:
- esbuild
- sharpThe PR instead introduces an allowBuilds key with an object-of-booleans value (pnpm-workspace.yaml:28-34). allowBuilds is not a pnpm setting, so pnpm ignores the entire block and continues to skip the build scripts for @google/genai, @livekit/local-inference, esbuild, onnxruntime-node, protobufjs, and sharp. This directly contradicts the PR's stated goal of explicitly allowing those postinstall scripts.
| allowBuilds: | |
| '@google/genai': true | |
| '@livekit/local-inference': true | |
| esbuild: true | |
| onnxruntime-node: true | |
| protobufjs: true | |
| sharp: true | |
| onlyBuiltDependencies: | |
| - '@google/genai' | |
| - '@livekit/local-inference' | |
| - esbuild | |
| - onnxruntime-node | |
| - protobufjs | |
| - sharp |
Was this helpful? React with 👍 or 👎 to provide feedback.
starting with pnpm v11 the
pnpmobject inpackage.jsongets ignored, so moving the dependency patch into pnpm-workspace instead.Explicitly allowed postinstallscripts for all of the current dependencies that made use of it. Please double check if they're all needed.