Skip to content

chore: update pnpm and ensure builds continue to work#2096

Merged
toubatbrian merged 4 commits into
mainfrom
lukas/pnpm-v11
Jul 23, 2026
Merged

chore: update pnpm and ensure builds continue to work#2096
toubatbrian merged 4 commits into
mainfrom
lukas/pnpm-v11

Conversation

@lukasIO

@lukasIO lukasIO commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

starting with pnpm v11 the pnpm object in package.json gets ignored, so moving the dependency patch into pnpm-workspace instead.

Explicitly allowed postinstallscripts for all of the current dependencies that made use of it. Please double check if they're all needed.

@lukasIO
lukasIO requested a review from a team as a code owner July 23, 2026 08:22
@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9b73c43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread pnpm-workspace.yaml
Comment on lines +28 to +34
allowBuilds:
'@google/genai': true
'@livekit/local-inference': true
esbuild: true
onnxruntime-node: true
protobufjs: true
sharp: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Dependency install scripts are silently disabled after the package manager upgrade

The list of dependencies whose install steps should run is written under an unrecognized setting name (allowBuilds at pnpm-workspace.yaml:28) instead of the setting the tool actually reads, so none of the listed dependencies' install steps run.
Impact: Native packages like sharp and onnxruntime-node never get built during install, which can make installs or agent runs fail at runtime.

Wrong pnpm setting key and value format

Starting with pnpm v11, packages with build/postinstall scripts are blocked by default unless explicitly allowlisted via the onlyBuiltDependencies setting, which takes a YAML list of package names:

onlyBuiltDependencies:
  - esbuild
  - sharp

The PR instead introduces an allowBuilds key with an object-of-booleans value (pnpm-workspace.yaml:28-34). allowBuilds is not a pnpm setting, so pnpm ignores the entire block and continues to skip the build scripts for @google/genai, @livekit/local-inference, esbuild, onnxruntime-node, protobufjs, and sharp. This directly contradicts the PR's stated goal of explicitly allowing those postinstall scripts.

Suggested change
allowBuilds:
'@google/genai': true
'@livekit/local-inference': true
esbuild: true
onnxruntime-node: true
protobufjs: true
sharp: true
onlyBuiltDependencies:
- '@google/genai'
- '@livekit/local-inference'
- esbuild
- onnxruntime-node
- protobufjs
- sharp
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration[bot]

This comment was marked as resolved.

@toubatbrian
toubatbrian merged commit 8d450e8 into main Jul 23, 2026
6 checks passed
@toubatbrian
toubatbrian deleted the lukas/pnpm-v11 branch July 23, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants