refactor(adk): consolidate store implementations#638
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 76.82% 76.92% +0.10%
==========================================
Files 473 473
Lines 66108 65850 -258
Branches 9821 9793 -28
==========================================
- Hits 50785 50656 -129
+ Misses 12031 11907 -124
+ Partials 3292 3287 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
ADK session, memory, and artifact implementations had parallel paths that were costly to keep aligned. Consolidating their shared state, SQL, and dispatch behavior reduces drift while retaining each adapter's native database operations.
Impact
No public API changes are intended. Existing synchronous and asynchronous stores retain their contracts, and adapter-specific SQL remains adapter-owned. Oracle sync session tables configured for hash partitioning now partition on the existing
idcolumn instead of the nonexistentsession_idcolumn. Spanner and BigQuery implementations are unchanged.Validation
make lintmake type-check