Repository navigation
Update Nginx configuration to replace $http_host with $host$is_request_port$request_port for better compatibility - #620
Conversation
|
I am a bot, here is the pushed image/manifest for this PR for commit a393925 :
|
|
I am a bot, here is the pushed image/manifest for this PR for commit 69afc4d :
|
nemchik
changed the title
|
I am a bot, here is the pushed image/manifest for this PR for commit a2509cc :
|
|
I am a bot, here is the pushed image/manifest for this PR for commit 6aa9d29 :
|
|
I am a bot, here is the pushed image/manifest for this PR for commit 0150bc7 :
|
|
I am a bot, here is the pushed image/manifest for this PR for commit aa0d432 :
|
|
I am a bot, here is the pushed image/manifest for this PR for commit 6df6b80 :
|
|
I am a bot, here is the pushed image/manifest for this PR for commit 41730c3 :
|
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@nemchik this looks good to me. Any chance you could rebase to master so the linuxserver team can have a look? |
james-d-elliott
left a comment
james-d-elliott
left a comment
There was a problem hiding this comment.
LGTM, formally endorsing this change.
…t_port$request_port for better compatibility Signed-off-by: GitHub <noreply@github.com>
41730c3 to
aeb7370
Compare
|
I am a bot, here is the pushed image/manifest for this PR for commit aeb7370 :
|
LinuxServer-CI
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
Requires: #622
Needs alpine 3.24 rebase for nginx 1.29.3 or higher (alpine 3.24 has nginx 1.30.3)
First commit switched from(rebase has replaced commits)$http_hostto$host:$server_portbut this breaks when standard ports (80/443) are used.From FonduemangVI on Discord
This misses the need for handling non-standard ports (ex: 8443) for the users that do that.
nginx has some variables to solve it though:
$host$is_request_port$request_portis the current recommended solution.NOTE:
$host$is_request_port$request_portshould only be used when constructing a URI. It should NOT be used when settingHost,X-Forwarded-Host,X-Forwarded-Server, etc because they are not constructing a URI. Comments have been added accordingly toproxy.conf.sampleI do not run proxy auth currently, so I have not tested these changes with proxy auth (comments from users below confirm it is working as intended).