You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Each sed reads the original template and overwrites the output, so only the last substitution survives: @@BIND_PROTO@@ and @@TIMEOUT_CLIENT@@ stay in /run/haproxy/haproxy.cfg, and haproxy -c rejects it:
[ALERT] config : parsing [haproxy.cfg:19] : unexpected character '@' in 'timeout client'
[ALERT] config : parsing [haproxy.cfg:29] : 'bind' : missing port specification in '@@BIND_PROTO@@'
One sed with all three expressions renders a config that validates:
Suggested change
sed "s/@@BIND_PROTO@@/${BIND_PROTO}/g" /templates/haproxy.cfg > /run/haproxy/haproxy.cfg
if [ "${TIMEOUT_CLIENT}" ];then
true
else
TIMEOUT_CLIENT="10"
fi
sed "s/@@TIMEOUT_CLIENT@@/${TIMEOUT_CLIENT}m/g" /templates/haproxy.cfg > /run/haproxy/haproxy.cfg
if [ "${TIMEOUT_SERVER}" ];then
true
else
TIMEOUT_SERVER="10"
fi
sed "s/@@TIMEOUT_SERVER@@/${TIMEOUT_SERVER}m/g" /templates/haproxy.cfg > /run/haproxy/haproxy.cfg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Closes #45
Benefits of this PR and context:
How Has This Been Tested?
Source / References: