Skip to content

chore: remove deprecated dde-network-dialog - #526

Merged
caixr23 merged 1 commit into
linuxdeepin:masterfrom
caixr23:master
Aug 10, 2026
Merged

chore: remove deprecated dde-network-dialog#526
caixr23 merged 1 commit into
linuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23

@caixr23 caixr23 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  1. Remove dde-network-dialog from Recommends in debian/control
  2. The package is deprecated and no longer needed as a recommended dependency

chore: 移除已弃用的 dde-network-dialog

  1. 从 debian/control 的 Recommends 中移除 dde-network-dialog
  2. 该包已弃用,不再需要作为推荐依赖

Summary by Sourcery

Remove the deprecated dde-network-dialog package from Debian packaging metadata.

Build:

  • Drop dde-network-dialog from the Recommends list in debian/control as it is deprecated.

Chores:

  • Clean up packaging dependencies by removing an obsolete recommended package.

1. Remove dde-network-dialog from Recommends in debian/control
2. The package is deprecated and no longer needed as a
   recommended dependency

chore: 移除已弃用的 dde-network-dialog

1. 从 debian/control 的 Recommends 中移除 dde-network-dialog
2. 该包已弃用,不再需要作为推荐依赖

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @caixr23, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@sourcery-ai

sourcery-ai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the deprecated dde-network-dialog package from the Debian control metadata so it is no longer listed as a recommended dependency.

File-Level Changes

Change Details Files
Drop deprecated dde-network-dialog from package Recommends to align dependencies with current requirements.
  • Update debian/control to remove dde-network-dialog from the Recommends field of the relevant package stanza
  • Ensure no other references to dde-network-dialog remain in that control entry
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码正确移除了dde-network-dialog推荐依赖,解耦了网络对话框组件,无任何风险
逻辑正确且符合规范,无需扣分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

debian/control文件中Recommends字段的修改去除了dde-network-dialog,保留了dss-network-plugin,没有遗留多余的逗号或破坏列表结构,符合Debian控制文件语法规范
潜在问题:无
建议:无

  • 2.代码质量(良好)✓

变更范围极小且精准,仅涉及目标依赖的剔除,没有引入无关的空白符修改或格式化变动,符合最小化修改原则
潜在问题:无
建议:无

  • 3.代码性能(无性能问题)✓

此变更为打包元数据修改,不涉及运行时逻辑、算法复杂度或系统调用,对系统性能无任何影响

建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
移除推荐依赖属于减少系统组件交集与潜在攻击面的正向安全操作,不会引入任何命令注入、路径遍历或权限绕过等安全风险

  • 建议:保持当前修改即可

■ 【改进建议代码示例】

--- a/debian/control
+++ b/debian/control
@@ -38,8 +38,7 @@ Depends: ${shlibs:Depends}, ${misc:Depends}, ${dist:Depends},
  xsettingsd,
  onboard
 Provides: lightdm-greeter
-Recommends: dss-network-plugin,
- dde-network-dialog
+Recommends: dss-network-plugin
 Conflicts: dde-workspace,
  deepin-notifications,
  dde-session-ui (<< 5.0.0),

@caixr23
caixr23 merged commit 30977ec into linuxdeepin:master Aug 10, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants